NO-ISSUE: Update module sigs.k8s.io/controller-runtime to v0.24.1#995
NO-ISSUE: Update module sigs.k8s.io/controller-runtime to v0.24.1#995red-hat-konflux[bot] wants to merge 1 commit into
Conversation
ℹ️ Artifact update noticeFile name: api/go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
File name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
|
@red-hat-konflux[bot]: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughBumps the Go toolchain to 1.26.0 and updates Kubernetes core and several indirect Go module versions in ChangesGo and Kubernetes dependency updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels: Suggested reviewers:
🚥 Pre-merge checks | ✅ 10 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a047ce3 to
a0c5ec0
Compare
a0c5ec0 to
e813ac3
Compare
e813ac3 to
c6038ce
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
c6038ce to
9536ba2
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@api/go.mod`:
- Around line 7-10: The go.mod versions are incompatible: update the
sigs.k8s.io/cluster-api version from v1.11.0 to a release that supports
Kubernetes v0.36.0 (e.g., v1.12.8 or v1.13.1) and align the controller-runtime
and k8s client libraries accordingly; specifically change
sigs.k8s.io/controller-runtime to a version that the chosen cluster-api release
was built against (replace v0.24.1 with the compatible controller-runtime
required by cluster-api v1.12.8/v1.13.1) and bump k8s.io/apimachinery and
k8s.io/client-go to the Kubernetes 1.36-compatible versions; ensure the final
set of versions for sigs.k8s.io/cluster-api, sigs.k8s.io/controller-runtime,
k8s.io/apimachinery, and k8s.io/client-go are mutually compatible before running
go mod tidy.
- Line 3: go.mod declares "go 1.26.0" but CI and container images are pinned to
older Go versions; update the go-version field in the GitHub Actions workflow
(the go-version key, e.g., currently '1.17.3') to '1.26.0' and update the base
image tags in the Dockerfile and Dockerfile.rhtap (replace occurrences of
"ubi9/go-toolset:1.25" and "rhel_9_1.25" respectively) to use Go
1.26.0-compatible images (match the semantic naming to 1.26.0) so all toolchains
match the go 1.26.0 declaration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 70ceb880-7dbc-4b1e-9466-bc011f731e86
⛔ Files ignored due to path filters (299)
api/go.sumis excluded by!**/*.sumapi/vendor/github.com/gogo/protobuf/AUTHORSis excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/CONTRIBUTORSis excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/Makefileis excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/clone.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/custom_gogo.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/decode.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/deprecated.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/discard.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/duration.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/duration_gogo.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/encode.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/encode_gogo.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/equal.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/extensions.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/extensions_gogo.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/lib.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/lib_gogo.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/message_set.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/pointer_reflect.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/pointer_reflect_gogo.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/pointer_unsafe.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/pointer_unsafe_gogo.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/properties.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/properties_gogo.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/skip_gogo.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/table_marshal.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/table_marshal_gogo.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/table_merge.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/table_unmarshal.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/table_unmarshal_gogo.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/text.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/text_gogo.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/text_parser.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/timestamp.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/timestamp_gogo.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/wrappers.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/proto/wrappers_gogo.gois excluded by!**/vendor/**api/vendor/github.com/gogo/protobuf/sortkeys/sortkeys.gois excluded by!**/vendor/**api/vendor/github.com/onsi/gomega/CHANGELOG.mdis excluded by!**/vendor/**api/vendor/github.com/onsi/gomega/format/format.gois excluded by!**/vendor/**api/vendor/github.com/onsi/gomega/gomega_dsl.gois excluded by!**/vendor/**api/vendor/github.com/onsi/gomega/matchers.gois excluded by!**/vendor/**api/vendor/github.com/onsi/gomega/matchers/have_key_matcher.gois excluded by!**/vendor/**api/vendor/github.com/onsi/gomega/matchers/have_key_with_value_matcher.gois excluded by!**/vendor/**api/vendor/github.com/onsi/gomega/matchers/match_error_strictly_matcher.gois excluded by!**/vendor/**api/vendor/github.com/onsi/gomega/matchers/support/goraph/edge/edge.gois excluded by!**/vendor/**api/vendor/golang.org/x/net/http2/transport.gois excluded by!**/vendor/**api/vendor/golang.org/x/net/http2/writesched_priority_rfc9218.gois excluded by!**/vendor/**api/vendor/golang.org/x/text/encoding/japanese/eucjp.gois excluded by!**/vendor/**api/vendor/golang.org/x/text/encoding/japanese/iso2022jp.gois excluded by!**/vendor/**api/vendor/golang.org/x/text/encoding/japanese/shiftjis.gois excluded by!**/vendor/**api/vendor/golang.org/x/text/encoding/korean/euckr.gois excluded by!**/vendor/**api/vendor/golang.org/x/text/encoding/simplifiedchinese/gbk.gois excluded by!**/vendor/**api/vendor/golang.org/x/text/encoding/simplifiedchinese/hzgb2312.gois excluded by!**/vendor/**api/vendor/golang.org/x/text/encoding/traditionalchinese/big5.gois excluded by!**/vendor/**api/vendor/golang.org/x/text/encoding/unicode/unicode.gois excluded by!**/vendor/**api/vendor/google.golang.org/protobuf/encoding/prototext/decode.gois excluded by!**/vendor/**api/vendor/google.golang.org/protobuf/internal/descfmt/stringer.gois excluded by!**/vendor/**api/vendor/google.golang.org/protobuf/internal/encoding/tag/tag.gois excluded by!**/vendor/**api/vendor/google.golang.org/protobuf/internal/encoding/text/decode.gois excluded by!**/vendor/**api/vendor/google.golang.org/protobuf/internal/filedesc/desc.gois excluded by!**/vendor/**api/vendor/google.golang.org/protobuf/internal/filedesc/desc_lazy.gois excluded by!**/vendor/**api/vendor/google.golang.org/protobuf/internal/genid/descriptor_gen.gois excluded by!**/vendor/**api/vendor/google.golang.org/protobuf/internal/impl/codec_map.gois excluded by!**/vendor/**api/vendor/google.golang.org/protobuf/internal/impl/decode.gois excluded by!**/vendor/**api/vendor/google.golang.org/protobuf/internal/impl/validate.gois excluded by!**/vendor/**api/vendor/google.golang.org/protobuf/internal/version/version.gois excluded by!**/vendor/**api/vendor/google.golang.org/protobuf/proto/decode.gois excluded by!**/vendor/**api/vendor/k8s.io/api/admissionregistration/v1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/admissionregistration/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/admissionregistration/v1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/admissionregistration/v1/register.gois excluded by!**/vendor/**api/vendor/k8s.io/api/admissionregistration/v1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/admissionregistration/v1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/admissionregistration/v1/zz_generated.deepcopy.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/admissionregistration/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/admissionregistration/v1/zz_generated.prerelease-lifecycle.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/admissionregistration/v1alpha1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/admissionregistration/v1alpha1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/admissionregistration/v1alpha1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/admissionregistration/v1alpha1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/admissionregistration/v1alpha1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/admissionregistration/v1alpha1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/admissionregistration/v1beta1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/admissionregistration/v1beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/admissionregistration/v1beta1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/admissionregistration/v1beta1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/admissionregistration/v1beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/admissionregistration/v1beta1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/admissionregistration/v1beta1/zz_generated.prerelease-lifecycle.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/apiserverinternal/v1alpha1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/apiserverinternal/v1alpha1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/apiserverinternal/v1alpha1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/apiserverinternal/v1alpha1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/apiserverinternal/v1alpha1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/apiserverinternal/v1alpha1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/apps/v1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/apps/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/apps/v1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/apps/v1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/apps/v1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/apps/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/apps/v1beta1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/apps/v1beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/apps/v1beta1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/apps/v1beta1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/apps/v1beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/apps/v1beta1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/apps/v1beta2/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/apps/v1beta2/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/apps/v1beta2/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/apps/v1beta2/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/apps/v1beta2/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/apps/v1beta2/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/authentication/v1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/authentication/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/authentication/v1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/authentication/v1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/authentication/v1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/authentication/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/authentication/v1alpha1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/authentication/v1alpha1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/authentication/v1alpha1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/authentication/v1alpha1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/authentication/v1alpha1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/authentication/v1alpha1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/authentication/v1beta1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/authentication/v1beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/authentication/v1beta1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/authentication/v1beta1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/authentication/v1beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/authentication/v1beta1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/authorization/v1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/authorization/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/authorization/v1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/authorization/v1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/authorization/v1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/authorization/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/authorization/v1beta1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/authorization/v1beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/authorization/v1beta1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/authorization/v1beta1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/authorization/v1beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/authorization/v1beta1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/autoscaling/v1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/autoscaling/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/autoscaling/v1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/autoscaling/v1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/autoscaling/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/autoscaling/v2/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/autoscaling/v2/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/autoscaling/v2/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/autoscaling/v2/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/autoscaling/v2/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/autoscaling/v2/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/autoscaling/v2beta1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/autoscaling/v2beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/autoscaling/v2beta1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/autoscaling/v2beta1/register.gois excluded by!**/vendor/**api/vendor/k8s.io/api/autoscaling/v2beta1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/autoscaling/v2beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/autoscaling/v2beta1/zz_generated.deepcopy.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/autoscaling/v2beta1/zz_generated.prerelease-lifecycle.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/autoscaling/v2beta2/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/autoscaling/v2beta2/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/autoscaling/v2beta2/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/autoscaling/v2beta2/register.gois excluded by!**/vendor/**api/vendor/k8s.io/api/autoscaling/v2beta2/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/autoscaling/v2beta2/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/autoscaling/v2beta2/zz_generated.deepcopy.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/autoscaling/v2beta2/zz_generated.prerelease-lifecycle.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/batch/v1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/batch/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/batch/v1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/batch/v1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/batch/v1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/batch/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/batch/v1beta1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/batch/v1beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/batch/v1beta1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/batch/v1beta1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/batch/v1beta1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/certificates/v1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/certificates/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/certificates/v1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/certificates/v1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/certificates/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/certificates/v1alpha1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/certificates/v1alpha1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/certificates/v1alpha1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/certificates/v1alpha1/register.gois excluded by!**/vendor/**api/vendor/k8s.io/api/certificates/v1alpha1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/certificates/v1alpha1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/certificates/v1alpha1/zz_generated.deepcopy.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/certificates/v1alpha1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/certificates/v1alpha1/zz_generated.prerelease-lifecycle.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/certificates/v1beta1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/certificates/v1beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/certificates/v1beta1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/certificates/v1beta1/register.gois excluded by!**/vendor/**api/vendor/k8s.io/api/certificates/v1beta1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/certificates/v1beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/certificates/v1beta1/zz_generated.deepcopy.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/certificates/v1beta1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/certificates/v1beta1/zz_generated.prerelease-lifecycle.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/coordination/v1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/coordination/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/coordination/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/coordination/v1alpha2/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/coordination/v1alpha2/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/coordination/v1alpha2/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/coordination/v1alpha2/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/coordination/v1alpha2/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/coordination/v1beta1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/coordination/v1beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/coordination/v1beta1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/coordination/v1beta1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/coordination/v1beta1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/core/v1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/core/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/core/v1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/core/v1/toleration.gois excluded by!**/vendor/**api/vendor/k8s.io/api/core/v1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/core/v1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/core/v1/zz_generated.deepcopy.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/core/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/discovery/v1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/discovery/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/discovery/v1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/discovery/v1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/discovery/v1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/discovery/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/discovery/v1beta1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/discovery/v1beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/discovery/v1beta1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/discovery/v1beta1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/discovery/v1beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/discovery/v1beta1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/events/v1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/events/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/events/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/events/v1beta1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/events/v1beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/events/v1beta1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/extensions/v1beta1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/extensions/v1beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/extensions/v1beta1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/extensions/v1beta1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/extensions/v1beta1/types_swagger_doc_generated.gois excluded by!**/vendor/**api/vendor/k8s.io/api/extensions/v1beta1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/extensions/v1beta1/zz_generated.validations.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/flowcontrol/v1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/flowcontrol/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/flowcontrol/v1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/flowcontrol/v1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/flowcontrol/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/flowcontrol/v1beta1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/flowcontrol/v1beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/flowcontrol/v1beta1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/flowcontrol/v1beta1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/flowcontrol/v1beta1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/flowcontrol/v1beta2/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/flowcontrol/v1beta2/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/flowcontrol/v1beta2/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/flowcontrol/v1beta2/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/flowcontrol/v1beta2/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/flowcontrol/v1beta3/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/flowcontrol/v1beta3/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/flowcontrol/v1beta3/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/flowcontrol/v1beta3/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/flowcontrol/v1beta3/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/networking/v1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/networking/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/networking/v1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/networking/v1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/networking/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/networking/v1beta1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/networking/v1beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/networking/v1beta1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/networking/v1beta1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/networking/v1beta1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/node/v1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/node/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/node/v1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/node/v1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/node/v1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/node/v1alpha1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/node/v1alpha1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/node/v1alpha1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/node/v1alpha1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/node/v1alpha1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/node/v1beta1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/node/v1beta1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**api/vendor/k8s.io/api/node/v1beta1/generated.protois excluded by!**/vendor/**api/vendor/k8s.io/api/node/v1beta1/types.gois excluded by!**/vendor/**api/vendor/k8s.io/api/node/v1beta1/zz_generated.model_name.gois excluded by!**/vendor/**,!**/zz_generated*api/vendor/k8s.io/api/policy/v1/doc.gois excluded by!**/vendor/**api/vendor/k8s.io/api/policy/v1/generated.pb.gois excluded by!**/*.pb.go,!**/vendor/**
📒 Files selected for processing (1)
api/go.mod
| module github.com/openshift/cluster-api-provider-agent/api | ||
|
|
||
| go 1.25.7 | ||
| go 1.26.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Read-only check for Go toolchain pins across repo config
set -euo pipefail
echo "== go.mod/go.work directives =="
rg -n --iglob 'go.mod' --iglob 'go.work' '^\s*go\s+|^\s*toolchain\s+'
echo
echo "== CI/build pins mentioning Go versions =="
rg -n --iglob '*.yaml' --iglob '*.yml' --iglob '*Dockerfile*' --iglob 'Makefile*' --iglob '*.mk' \
'golang:1\.[0-9]+|go-version|GOTOOLCHAIN|GO_VERSION|1\.26(\.0)?'Repository: openshift/cluster-api-provider-agent
Length of output: 1068
🏁 Script executed:
# Search for actual CI workflow files
find . -path ./vendor -prune -o -type f \( -name '*.yaml' -o -name '*.yml' \) -print | grep -E '(\.github|gitlab|drone|circleci)' | head -20Repository: openshift/cluster-api-provider-agent
Length of output: 111
🏁 Script executed:
# Search for Dockerfile and Makefile in repo root
find . -maxdepth 3 -path ./vendor -prune -o -type f \( -name 'Dockerfile*' -o -name 'Makefile' \) -print | grep -v vendorRepository: openshift/cluster-api-provider-agent
Length of output: 123
🏁 Script executed:
# Check for go.work file
find . -maxdepth 2 -name 'go.work' -not -path './vendor/*'Repository: openshift/cluster-api-provider-agent
Length of output: 62
🏁 Script executed:
# Search for Go version pins in non-vendored workflow/CI files
rg -t yaml -t yml '(golang|go).*1\.[0-9]+' --glob '!vendor' | head -30Repository: openshift/cluster-api-provider-agent
Length of output: 108
🏁 Script executed:
cat .github/workflows/build.yamlRepository: openshift/cluster-api-provider-agent
Length of output: 1713
🏁 Script executed:
cat DockerfileRepository: openshift/cluster-api-provider-agent
Length of output: 814
🏁 Script executed:
cat Dockerfile.rhtapRepository: openshift/cluster-api-provider-agent
Length of output: 1490
🏁 Script executed:
cat -n Makefile | head -100Repository: openshift/cluster-api-provider-agent
Length of output: 5850
Update GitHub Actions, Dockerfile, and Dockerfile.rhtap to use Go 1.26.0.
The api/go.mod declares go 1.26.0 but CI/build toolchains are pinned to older versions:
.github/workflows/build.yaml:go-version: '1.17.3'Dockerfile:ubi9/go-toolset:1.25Dockerfile.rhtap:rhel_9_1.25
These mismatches will cause build failures. Update all three to Go 1.26.0.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@api/go.mod` at line 3, go.mod declares "go 1.26.0" but CI and container
images are pinned to older Go versions; update the go-version field in the
GitHub Actions workflow (the go-version key, e.g., currently '1.17.3') to
'1.26.0' and update the base image tags in the Dockerfile and Dockerfile.rhtap
(replace occurrences of "ubi9/go-toolset:1.25" and "rhel_9_1.25" respectively)
to use Go 1.26.0-compatible images (match the semantic naming to 1.26.0) so all
toolchains match the go 1.26.0 declaration.
| k8s.io/apimachinery v0.36.0 | ||
| k8s.io/client-go v0.36.0 | ||
| sigs.k8s.io/cluster-api v1.11.0 | ||
| sigs.k8s.io/controller-runtime v0.22.4 | ||
| sigs.k8s.io/controller-runtime v0.24.1 |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
For sigs.k8s.io/cluster-api v1.11.0, what Kubernetes and controller-runtime versions are officially supported? Specifically, is it compatible with k8s.io/* v0.36.0 (Kubernetes 1.36) and sigs.k8s.io/controller-runtime v0.24.1? Please cite upstream release notes/docs.
💡 Result:
For Cluster API v1.11.0, the supported Kubernetes versions range from v1.28.x to v1.33.x [1]. Cluster API v1.11 is not compatible with Kubernetes v1.36; support for Kubernetes v1.36 in the v1.11 minor release line is only available starting from v1.11.8 [2]. Regarding controller-runtime, Cluster API v1.11.0 was released with controller-runtime v0.21.0 [1]. It is not compatible with controller-runtime v0.24.1, which is explicitly tied to Kubernetes v1.36 and higher [3][4]. The Cluster API project maintains specific minor versions of controller-runtime for its releases and does not support arbitrary upgrades to newer, incompatible controller-runtime versions [2][4]. In summary, neither Kubernetes v1.36 nor controller-runtime v0.24.1 are officially supported by Cluster API v1.11.0 [1][2][3]. To use Kubernetes v1.36, you must use a newer version of Cluster API that supports it (such as v1.12.8 or v1.13.1) [2].
Citations:
- 1: https://github.com/kubernetes-sigs/cluster-api/releases/tag/v1.11.0
- 2: https://cluster-api.sigs.k8s.io/reference/versions
- 3: https://pkg.go.dev/sigs.k8s.io/controller-runtime
- 4: https://github.com/kubernetes-sigs/controller-runtime
Resolve version incompatibilities: cluster-api v1.11.0 does not support Kubernetes v0.36.0 or controller-runtime v0.24.1.
Cluster API v1.11.0 officially supports only Kubernetes v1.28–v1.33 and was released with controller-runtime v0.21.0. For Kubernetes 1.36 support, upgrade to Cluster API v1.12.8, v1.13.1, or later.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@api/go.mod` around lines 7 - 10, The go.mod versions are incompatible: update
the sigs.k8s.io/cluster-api version from v1.11.0 to a release that supports
Kubernetes v0.36.0 (e.g., v1.12.8 or v1.13.1) and align the controller-runtime
and k8s client libraries accordingly; specifically change
sigs.k8s.io/controller-runtime to a version that the chosen cluster-api release
was built against (replace v0.24.1 with the compatible controller-runtime
required by cluster-api v1.12.8/v1.13.1) and bump k8s.io/apimachinery and
k8s.io/client-go to the Kubernetes 1.36-compatible versions; ensure the final
set of versions for sigs.k8s.io/cluster-api, sigs.k8s.io/controller-runtime,
k8s.io/apimachinery, and k8s.io/client-go are mutually compatible before running
go mod tidy.
This PR contains the following updates:
v0.22.4→v0.24.1Release Notes
kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)
v0.24.1Compare Source
What's Changed
Full Changelog: kubernetes-sigs/controller-runtime@v0.24.0...v0.24.1
v0.24.0Compare Source
🐛 Bug Fixes
🌱 Others
StartLoggingfor event debug logs (#3451)🌱 CI & linters
tools/setup-envtestsubmodule (#3476)📖 Additionally, there has been 1 contribution to our documentation. (#3477)
Dependencies
Added
Changed
8a7402a→944ab1f078029d→bd525daa0af3ef→8636f87200df99→8636f87f2248ac589584f→43fb72cbc988d5→b8788abRemoved
9bdfabeThanks to all our contributors! 😊
v0.23.3Compare Source
What's Changed
Full Changelog: kubernetes-sigs/controller-runtime@v0.23.2...v0.23.3
v0.23.2Compare Source
What's Changed
Full Changelog: kubernetes-sigs/controller-runtime@v0.23.1...v0.23.2
v0.23.1Compare Source
What's Changed
Full Changelog: kubernetes-sigs/controller-runtime@v0.23.0...v0.23.1
v0.23.0Compare Source
🔆 Highlights
GetEventRecorderForrequires updating your rbac for events to use theevents.k8s.ioapiGroup rather than the `` (core) apiGroupbuilder.WebhookManagedBy(mgr).For(&corev1.Deployment{})has to be changed tobuilder.WebhookManagedBy(mgr, &appsv1.Deployment{})runtime.Object, for example fromValidateCreate(ctx context.Context, obj runtime.Object) (admission.Warnings, error)toValidateCreate(ctx context.Context, obj *appsv1.Deployment) (admission.Warnings, error)✨ Features
🐛 Bugfixes
waitermanipulation by @fossedihelm in #3368🌱 Other
sorttoslicespackage by @dongjiang1989 in #3370📖 Documentation
README.md's compatibility matrix forv0.22.x. by @renormalize in #3392Dependencies
Added
Changed
bda5523→078029d5ec99f8→9bdfabea0af3ef→200df9985fd79d→ec3ebc5f3f2b99→589584f4c0f3b2→bc988d5cfa47c3→2d32026Removed
New Contributors
Full Changelog: kubernetes-sigs/controller-runtime@v0.22.0...v0.23.0
Thanks to all our contributors! 😊
v0.22.5Compare Source
What's Changed
Full Changelog: kubernetes-sigs/controller-runtime@v0.22.4...v0.22.5
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.